Implement Quotes Board #1029

christolis · 2024-02-21T13:29:53Z

Closes #1027.

Screenshots

Configuration changes

Property	Description	Type	Default
`coolMessagesConfig.minimumReaction`	The minimum amount of reactions needed for the target message to be considered to the board channel.	int	5
`coolMessagesConfig.boardChannelPattern`	A pattern of the channel where messages that should be quoted get posted to.	String	`"quotes"`
`coolMessagesConfig.reactionEmoji`	The reaction emoji as unicode.	String	`"U+2B50"`

application/src/main/java/org/togetherjava/tjbot/features/Features.java

application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java

Taz03

add a message about config changes on main pr message, moderators said its hard to keep track of it otherwise

application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java

SquidXTV · 2024-10-15T09:53:07Z

maybe it makes more sense to implement this with the new forward feature in discord?

christolis · 2024-10-29T19:52:59Z

maybe it makes more sense to implement this with the new forward feature in discord?

@SquidXTV This is now a feature! With the latest changes, we are now forwarding messages instead of embedding messages. Good suggestion :)

SquidXTV · 2024-10-29T20:18:56Z

@SquidXTV This is now a feature! With the latest changes, we are now forwarding messages instead of embedding messages. Good suggestion :)

Good job <3
Maybe update the PR description (Screenshot) accordingly

christolis · 2024-10-29T20:21:43Z

@SquidXTV This is now a feature! With the latest changes, we are now forwarding messages instead of embedding messages. Good suggestion :)

Good job <3 Maybe update the PR description (Screenshot) accordingly

Thank you! I have updated the PR description. Thanks for pointing it out!

All requests have been resolved

application/src/main/java/org/togetherjava/tjbot/config/CoolMessagesBoardConfig.java

application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java

application/config.json.template

application/build.gradle

suryatejess · 2025-06-27T18:50:15Z

gonna help with this

For this feature, the version of JDA had to be bumped to 5.1.2

* minimumReactions-5, star symbol instead of encoding * requests changes by zabuzard except for moving getBoardChannel down and markMessageAsProcessed * Following JavaDocs guidelines of making the first letter capital * code refactoring * refactor: use correct method for reactionsCount It turns out that for each event fired, every *single* damn time, messageReaction.hasCount() would always return false. No matter what. Terrible documentation from JDA's side. As a result, because of the ternary operator: messageReaction.hasCount() ? messageReaction.getCount() + 1 : 1 the result of `reactionsCount` would always end up holding the value of one. In the following changes, we use `messageReaction.retrieveUsers()` to get a list of the people reacted, get a `Stream<User>` from that and get its count. Much more reliable this way and it also happens to be more readable. Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com> Co-authored-by: Chris Sdogkos <work@chris-sdogkos.com> Co-authored-by: Surya Tejess <74978874+suryatejess@users.noreply.github.com>

CLAassistant · 2025-06-28T14:10:18Z

All committers have signed the CLA.

Since 1ade409 (refactor: code review addressed by Zabuzard, 2025-06-28) primarily contains a generaly vague JavaDoc describing what the `QuoteBoardForwarder.java` class is doing, a more descriptive one replaces it. Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

Zabuzard · 2025-06-30T09:09:09Z

application/config.json.template

@@ -175,5 +175,10 @@
        "fallbackChannelPattern": "java-news-and-changes",
        "pollIntervalInMinutes": 10
    },
+    "coolMessagesConfig": {


please rename it here as well, thanks

Zabuzard · 2025-06-30T09:09:31Z

application/src/main/java/org/togetherjava/tjbot/config/Config.java

@@ -48,6 +48,7 @@ public final class Config {
    private final RSSFeedsConfig rssFeedsConfig;
    private final String selectRolesChannelPattern;
    private final String memberCountCategoryPattern;
+    private final QuoteBoardConfig coolMessagesConfig;


rename here as well

Zabuzard · 2025-06-30T09:09:44Z

application/src/main/java/org/togetherjava/tjbot/config/Config.java

+                    required = true) String selectRolesChannelPattern,
+            @JsonProperty(value = "coolMessagesConfig",
+                    required = true) QuoteBoardConfig coolMessagesConfig) {


rename here as well

Zabuzard · 2025-06-30T09:09:47Z

application/src/main/java/org/togetherjava/tjbot/config/Config.java

@@ -135,6 +138,7 @@ private Config(@JsonProperty(value = "token", required = true) String token,
        this.featureBlacklistConfig = Objects.requireNonNull(featureBlacklistConfig);
        this.rssFeedsConfig = Objects.requireNonNull(rssFeedsConfig);
        this.selectRolesChannelPattern = Objects.requireNonNull(selectRolesChannelPattern);
+        this.coolMessagesConfig = Objects.requireNonNull(coolMessagesConfig);


rename here as well

Zabuzard · 2025-06-30T09:11:25Z

application/src/main/java/org/togetherjava/tjbot/config/Config.java

+    /**
+     * The configuration of the cool messages config.
+     *
+     * @return configuration of cool messages config
+     */
+    public QuoteBoardConfig getCoolMessagesConfig() {
+        return coolMessagesConfig;
+    }


rename here as well

id also appreciate if we add a second sentence to the javadoc here to summarize the feature quickly. perhaps:

The configuration of the quote board feature. Quotes user selected messages.

Zabuzard · 2025-06-30T09:13:30Z

application/src/main/java/org/togetherjava/tjbot/config/QuoteBoardConfig.java

+     * @param reactionEmoji the emoji with which users should react to
+     */
+    public QuoteBoardConfig {
+        Objects.requireNonNull(boardChannelPattern);


is that possibly missing checks on the other params as well?

I feel like the checks for minimumReactions, and reactionEmoji is not required in the record constructor as they'd already be configured in the config template

But there is a possibility that there might not be a channel on the server with the name contained by theboardChannelPattern variable and hence we need it here.

they are all (rightfully) marked as required though. so we need to check they are actually set to a non null value

sounds fair

since minimumReactions is an integer, i dont think we need to perform a check for it

aye. but the other one is a string 👍

Zabuzard · 2025-06-30T09:13:59Z

application/src/main/java/org/togetherjava/tjbot/features/basic/QuoteBoardForwarder.java

+import java.util.regex.Pattern;
+
+/**
+ * Listens for reaction-add events and turns popular messages into “quotes”.


no smart-quotes please. just "

Zabuzard · 2025-06-30T09:15:14Z

application/src/main/java/org/togetherjava/tjbot/features/basic/QuoteBoardForwarder.java

+    @Override
+    public void onMessageReactionAdd(MessageReactionAddEvent event) {
+        final MessageReaction messageReaction = event.getReaction();
+        boolean isCoolEmoji = messageReaction.getEmoji().equals(triggerReaction);


id rename that to sth like isTriggerEmoji

Zabuzard · 2025-06-30T09:16:29Z

application/src/main/java/org/togetherjava/tjbot/features/basic/QuoteBoardForwarder.java

+        }
+
+        final int reactionsCount = (int) messageReaction.retrieveUsers().stream().count();
+        if (isCoolEmoji && reactionsCount >= config.minimumReactions()) {


personally id favor early-return to reduce the nesting here.

Zabuzard · 2025-06-30T09:17:06Z

application/src/main/java/org/togetherjava/tjbot/features/basic/QuoteBoardForwarder.java

+        boolean isCoolEmoji = messageReaction.getEmoji().equals(triggerReaction);
+        long guildId = event.getGuild().getIdLong();
+
+        if (hasAlreadyForwardedMessage(event.getJDA(), messageReaction)) {
+            return;
+        }
+
+        final int reactionsCount = (int) messageReaction.retrieveUsers().stream().count();
+        if (isCoolEmoji && reactionsCount >= config.minimumReactions()) {


there is no need to do the hasAlreadyForwardedMessage and the reactionsCount computation if (!isCoolEmoji). add an early-return.

christolis requested review from a team as code owners February 21, 2024 13:29

Taz03 marked this pull request as draft February 22, 2024 00:43

Taz03 assigned christolis Feb 22, 2024

christolis marked this pull request as ready for review February 28, 2024 10:27

tj-wazei previously requested changes Mar 1, 2024

View reviewed changes

tj-wazei reviewed Mar 1, 2024

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java Outdated Show resolved Hide resolved

christolis force-pushed the feature/cool-messages branch from 4a68771 to bc3b7d6 Compare March 1, 2024 23:54

christolis marked this pull request as draft March 2, 2024 00:03

christolis marked this pull request as ready for review March 2, 2024 00:59

christolis requested a review from tj-wazei March 2, 2024 01:00

christolis force-pushed the feature/cool-messages branch from 35ba891 to 47cdcb2 Compare March 20, 2024 09:29

Taz03 requested changes Mar 20, 2024

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java Outdated Show resolved Hide resolved

christolis force-pushed the feature/cool-messages branch from 47cdcb2 to 6d86c8f Compare April 4, 2024 09:07

christolis requested a review from Taz03 April 4, 2024 09:43

Taz03 previously approved these changes Apr 14, 2024

View reviewed changes

christolis dismissed Taz03’s stale review via 59dc245 May 17, 2024 22:42

christolis force-pushed the feature/cool-messages branch from ed3dbd5 to 59dc245 Compare May 17, 2024 22:42

ankitsmt211 added the config-changes if your PR contains any changes related to config file label May 18, 2024

christolis force-pushed the feature/cool-messages branch from 59dc245 to 35abd02 Compare October 6, 2024 11:44

christolis force-pushed the feature/cool-messages branch from 35abd02 to 7b19538 Compare October 29, 2024 19:50

christolis force-pushed the feature/cool-messages branch 2 times, most recently from bbde421 to 7d839d6 Compare October 29, 2024 20:13

SquidXTV previously approved these changes Oct 30, 2024

View reviewed changes

christolis requested a review from Taz03 October 30, 2024 10:20

tj-wazei previously approved these changes Oct 30, 2024

View reviewed changes

Zabuzard requested changes Jun 26, 2025

View reviewed changes

christolis dismissed stale reviews from tj-wazei and SquidXTV via 9f303cd June 26, 2025 10:50

christolis force-pushed the feature/cool-messages branch 2 times, most recently from 9f303cd to 8407d3f Compare June 27, 2025 09:00

christolis assigned suryatejess Jun 27, 2025

christolis added 3 commits June 28, 2025 16:59

feat(cool-messages): add configuration files

e1dcd79

feat(cool-messages): add primary logic

26e7811

feat(cool-message): forward messages instead of using embed

fb4fb5d

For this feature, the version of JDA had to be bumped to 5.1.2

christolis force-pushed the feature/cool-messages branch from 8407d3f to fb4fb5d Compare June 28, 2025 14:05

christolis requested a review from Zabuzard June 28, 2025 15:57

Zabuzard requested changes Jun 30, 2025

View reviewed changes

christolis force-pushed the feature/cool-messages branch 2 times, most recently from c3c1579 to a6085db Compare June 30, 2025 10:22

Zabuzard added the priority: normal label Jul 1, 2025

Uh oh!

Implement Quotes Board #1029

Are you sure you want to change the base?

Implement Quotes Board #1029

Conversation

christolis commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

Configuration changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Taz03 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SquidXTV commented Oct 15, 2024

Uh oh!

christolis commented Oct 29, 2024

Uh oh!

SquidXTV commented Oct 29, 2024

Uh oh!

christolis commented Oct 29, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

suryatejess commented Jun 27, 2025

Uh oh!

CLAassistant commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suryatejess Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suryatejess Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

christolis commented Feb 21, 2024 •

edited

Loading

CLAassistant commented Jun 28, 2025 •

edited

Loading

suryatejess Jun 30, 2025 •

edited

Loading

suryatejess Jun 30, 2025 •

edited

Loading